Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate tolerations keys for metallb chart #1249

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

vespian
Copy link
Contributor

@vespian vespian commented Nov 23, 2021

What type of PR is this?
Bug

What this PR does/ why we need it:
Duplicate keys cause Flux to fail, see fluxcd/helm-controller#283 Additionally, the node-role.kubernetes.io/master will no longer be removed/lost in case when new tolerations are defined.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Defining custom tolerations for metallb speaker no longer results in removing/forgetting of `node-role.kubernetes.io/master` toleration.

Checklist

  • If a chart is changed, the chart version is correctly incremented.
  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@vespian vespian self-assigned this Nov 23, 2021
@vespian vespian requested a review from a team as a code owner November 23, 2021 16:29
Copy link
Contributor

@tillt tillt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tillt tillt merged commit de0218e into master Nov 24, 2021
@tillt tillt deleted the prozlach/remove_duplicate_keys branch November 24, 2021 11:50
d2iq-dispatch added a commit that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants